Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rest single vote and inactive proposal votes list queries #6388

Merged
merged 3 commits into from
Jun 15, 2020

Conversation

akhilkumarpilli
Copy link
Contributor

Description

closes: #6302

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@akhilkumarpilli akhilkumarpilli marked this pull request as ready for review June 10, 2020 11:41
@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #6388 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #6388      +/-   ##
==========================================
+ Coverage   55.72%   55.79%   +0.07%     
==========================================
  Files         465      465              
  Lines       27782    27785       +3     
==========================================
+ Hits        15481    15504      +23     
+ Misses      11197    11176      -21     
- Partials     1104     1105       +1     

@fedekunze fedekunze added the A:automerge Automatically merge PR once all prerequisites pass. label Jun 11, 2020
@alessio
Copy link
Contributor

alessio commented Jun 11, 2020

Please @akhilkumarpilli either rebase to master or merge master in.

@akhilkumarpilli akhilkumarpilli force-pushed the akhil/rest-votes-issue branch from 86023e1 to 28d335d Compare June 11, 2020 08:54
@tac0turtle
Copy link
Member

@akhilkumarpilli could you please merge master into this branch.

@fedekunze fedekunze merged commit 6336f95 into cosmos:master Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/gov
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rest /gov/proposals/{proposal-id}/votes/{voter} always fails for inactive proposals.
5 participants