Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert x/bank query CLI commands to use gRPC query client #6367

Merged
merged 11 commits into from
Jun 18, 2020

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Jun 8, 2020

ref: #5921

This PR:

  • converts the x/bank balances and total CLI query commands to use the gRPC QueryClient
  • updates client.Context.PrintOutput to properly work with protobuf and amino (including unit tests), and removes client.Context.Println which was initially intended to replace PrintOutput for protobuf but is no longer needed

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #6367 into master will increase coverage by 0.07%.
The diff coverage is 48.27%.

@@            Coverage Diff             @@
##           master    #6367      +/-   ##
==========================================
+ Coverage   55.98%   56.06%   +0.07%     
==========================================
  Files         466      466              
  Lines       27908    27904       -4     
==========================================
+ Hits        15623    15643      +20     
+ Misses      11180    11149      -31     
- Partials     1105     1112       +7     

@lgtm-com
Copy link

lgtm-com bot commented Jun 8, 2020

This pull request introduces 2 alerts when merging 9d34409 into 65ea305 - view on LGTM.com

new alerts:

  • 2 for Useless assignment to local variable

@aaronc aaronc mentioned this pull request Jun 10, 2020
11 tasks
@clevinson clevinson added this to the v0.39 milestone Jun 11, 2020
@aaronc aaronc mentioned this pull request Jun 16, 2020
8 tasks
@aaronc aaronc changed the title Convert x/bank query cli methods to use gRPC query client Convert x/bank query CLI methods to use gRPC query client Jun 17, 2020
@aaronc aaronc changed the title Convert x/bank query CLI methods to use gRPC query client Convert x/bank query CLI commands to use gRPC query client Jun 17, 2020
@aaronc aaronc marked this pull request as ready for review June 17, 2020 19:12
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ☕

@fedekunze fedekunze merged commit 257354d into master Jun 18, 2020
@fedekunze fedekunze deleted the aaronc/5921-grpc-x-bank-cli branch June 18, 2020 07:36
@aaronc aaronc mentioned this pull request Jul 1, 2020
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants