-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert x/bank query CLI commands to use gRPC query client #6367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6367 +/- ##
==========================================
+ Coverage 55.98% 56.06% +0.07%
==========================================
Files 466 466
Lines 27908 27904 -4
==========================================
+ Hits 15623 15643 +20
+ Misses 11180 11149 -31
- Partials 1105 1112 +7 |
This pull request introduces 2 alerts when merging 9d34409 into 65ea305 - view on LGTM.com new alerts:
|
…ronc/5921-grpc-x-bank-cli
…ronc/5921-grpc-x-bank-cli
…ronc/5921-grpc-x-bank-cli
aaronc
changed the title
Convert x/bank query cli methods to use gRPC query client
Convert x/bank query CLI methods to use gRPC query client
Jun 17, 2020
aaronc
changed the title
Convert x/bank query CLI methods to use gRPC query client
Convert x/bank query CLI commands to use gRPC query client
Jun 17, 2020
aaronc
requested review from
alessio,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
June 17, 2020 19:12
fedekunze
approved these changes
Jun 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK ☕
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #5921
This PR:
x/bank
balances
andtotal
CLI query commands to use the gRPCQueryClient
client.Context.PrintOutput
to properly work with protobuf and amino (including unit tests), and removesclient.Context.Println
which was initially intended to replacePrintOutput
for protobuf but is no longer neededBefore we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorer