Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADR 021 - Protocol Buffer Query Support #5894

Merged
merged 9 commits into from
Apr 2, 2020
Merged

ADR 021 - Protocol Buffer Query Support #5894

merged 9 commits into from
Apr 2, 2020

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Mar 30, 2020 •
edited by alexanderbez
Loading

/cc @alexanderbez

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@tac0turtle tac0turtle added the R4R label Mar 31, 2020
aaronc and others added 7 commits April 1, 2020 11:07
@aaronc
Add ADR 021 draft
3c3ab5c
@aaronc @fedekunze
Update docs/architecture/README.md
249d640 
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
@aaronc
Add Swagger Generation heading
ad81028
@aaronc @alexanderbez
Update docs/architecture/adr-021-protobuf-query-encoding.md
0bc9347 
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
@aaronc @alexanderbez
Update docs/architecture/adr-021-protobuf-query-encoding.md
563ecba 
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
@aaronc @alexanderbez
Update docs/architecture/adr-021-protobuf-query-encoding.md
bcd2110 
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
@aaronc
Updates based on PR review
e3f9ee5
@aaronc aaronc force-pushed the aaronc/adr-021-proto-query branch from fc47769 to e3f9ee5 Compare April 1, 2020 15:07
alexanderbez
alexanderbez approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK -- don't want to keep this ADR in limbo. Further tweaks can be made as implementation proceeds.

@aaronc aaronc mentioned this pull request Apr 2, 2020
Open
@aaronc aaronc merged commit e8a82f7 into cosmos:master Apr 2, 2020
@aaronc aaronc deleted the aaronc/adr-021-proto-query branch April 2, 2020 16:07
This was referenced Apr 3, 2020
Closed
Closed
@aaronc aaronc mentioned this pull request Apr 16, 2020
Closed
11 tasks
@clevinson clevinson added this to the v0.39 milestone May 4, 2020
This was referenced May 11, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze left review comments

@tac0turtle tac0turtle tac0turtle left review comments

@alexanderbez alexanderbez alexanderbez approved these changes

@alessio alessio Awaiting requested review from alessio

@hschoenburg hschoenburg Awaiting requested review from hschoenburg

@nylira nylira Awaiting requested review from nylira

Assignees

@aaronc aaronc

Labels
None yet
Projects
None yet
Milestone
v0.40 [Stargate]
Development

Successfully merging this pull request may close these issues.
5 participants
@aaronc @alexanderbez @tac0turtle @fedekunze @clevinson