Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove keyring lazy implementation #5104

Merged
merged 18 commits into from
Sep 30, 2019
Merged

Remove keyring lazy implementation #5104

merged 18 commits into from
Sep 30, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Sep 25, 2019 •
edited
Loading

Remove "lazy" keyring implementation as it's
entirely unnecessary.

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio alessio mentioned this pull request Sep 25, 2019
Merged
5 tasks
golangcibot
golangcibot reviewed Sep 25, 2019
View reviewed changes
crypto/keys/keyring.go Outdated Show resolved Hide resolved
@alessio alessio force-pushed the alessio/remove-lazykeyring branch from 3835d09 to f30bd3a Compare September 25, 2019 21:44
@codecov
Copy link

codecov bot commented Sep 25, 2019 •
edited
Loading

Codecov Report

Merging #5104 into master will increase coverage by 0.08%.
The diff coverage is 38.58%.

@@            Coverage Diff             @@
##           master    #5104      +/-   ##
==========================================
+ Coverage   54.87%   54.96%   +0.08%     
==========================================
  Files         296      295       -1     
  Lines       18336    18235     -101     
==========================================
- Hits        10062    10022      -40     
+ Misses       7524     7476      -48     
+ Partials      750      737      -13

@alessio alessio changed the title WIP: remove keyring lazy implementation Remove keyring lazy implementation Sep 30, 2019
@alessio alessio marked this pull request as ready for review September 30, 2019 15:43
@alexanderbez alexanderbez added C:Keys Keybase, KMS and HSMs R4R labels Sep 30, 2019
golangcibot
golangcibot reviewed Sep 30, 2019
View reviewed changes
crypto/keys/keyring.go Show resolved Hide resolved
crypto/keys/keyring.go Show resolved Hide resolved
crypto/keys/keyring.go Show resolved Hide resolved
alexanderbez
alexanderbez approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 🎉

@alexanderbez alexanderbez merged commit 46cd611 into master Sep 30, 2019
@alexanderbez alexanderbez deleted the alessio/remove-lazykeyring branch September 30, 2019 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@alexanderbez alexanderbez alexanderbez approved these changes

@fedekunze fedekunze Awaiting requested review from fedekunze

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
C:Keys Keybase, KMS and HSMs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alessio @alexanderbez @golangcibot