-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blacklist module accounts from receiving txs #4797
Conversation
115d91e
to
adf6ddd
Compare
Codecov Report
@@ Coverage Diff @@
## master #4797 +/- ##
==========================================
+ Coverage 50.5% 50.54% +0.03%
==========================================
Files 288 288
Lines 18518 18596 +78
==========================================
+ Hits 9353 9399 +46
- Misses 8480 8506 +26
- Partials 685 691 +6 |
Codecov Report
@@ Coverage Diff @@
## master #4797 +/- ##
==========================================
+ Coverage 50.39% 50.59% +0.19%
==========================================
Files 288 288
Lines 18520 18546 +26
==========================================
+ Hits 9334 9384 +50
+ Misses 8501 8477 -24
Partials 685 685 |
…dekunze/4795-fix-macc-inv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor nit, but otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK ☕️
Co-Authored-By: colin axner <colinaxner@berkeley.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking on spec update and similar changes to distribution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny nitpick
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK ⚡️
Fixes: #4795
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added a relevant changelog entry:
clog add [section] [-t <tag>] [-m <msg>]
Re-reviewed
Files changed
in the github PR explorerFor Admin Use: