Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix master Build #4659

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Fix master Build #4659

merged 1 commit into from
Jul 2, 2019

Conversation

alexanderbez
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jul 2, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@f1b08b8). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4659   +/-   ##
=========================================
  Coverage          ?   55.06%           
=========================================
  Files             ?      273           
  Lines             ?    17086           
  Branches          ?        0           
=========================================
  Hits              ?     9408           
  Misses            ?     6984           
  Partials          ?      694

@alexanderbez alexanderbez marked this pull request as ready for review July 2, 2019 04:34
@alexanderbez alexanderbez added R4R and removed WIP labels Jul 2, 2019
@alexanderbez alexanderbez requested a review from fedekunze July 2, 2019 04:34
@alessio alessio merged commit b3a8195 into master Jul 2, 2019
@alessio alessio deleted the bez/fix-master-build branch July 2, 2019 11:01
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants