Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize Querier REST Pagination #4658

Merged
merged 6 commits into from
Jul 2, 2019
Merged

Generalize Querier REST Pagination #4658

merged 6 commits into from
Jul 2, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Jul 2, 2019 •
edited
Loading

closes #4601

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez added WIP Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. labels Jul 2, 2019
@alexanderbez alexanderbez marked this pull request as ready for review July 2, 2019 01:51
@alexanderbez alexanderbez added R4R and removed WIP labels Jul 2, 2019
fedekunze
fedekunze approved these changes Jul 2, 2019
View reviewed changes
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending clog

@alexanderbez alexanderbez merged commit aba1f64 into master Jul 2, 2019
@alexanderbez alexanderbez deleted the bez/4601-gen-rest-pagination branch July 2, 2019 13:00
@codecov
Copy link

codecov bot commented Jul 2, 2019

Codecov Report

Merging #4658 into master will increase coverage by 0.03%.
The diff coverage is 66.66%.

@@            Coverage Diff            @@
##           master   #4658      +/-   ##
=========================================
+ Coverage   55.06%   55.1%   +0.03%     
=========================================
  Files         273     274       +1     
  Lines       17086   17081       -5     
=========================================
+ Hits         9408    9412       +4     
+ Misses       6984    6976       -8     
+ Partials      694     693       -1

@antho1404 antho1404 mentioned this pull request Feb 26, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@alessio alessio Awaiting requested review from alessio

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@colin-axner colin-axner Awaiting requested review from colin-axner

Assignees
No one assigned
Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generalize pagination logic for queriers
2 participants
@alexanderbez @fedekunze