-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate account getters from client/context #4579
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4579 +/- ##
==========================================
+ Coverage 52.61% 52.66% +0.04%
==========================================
Files 263 264 +1
Lines 16464 16483 +19
==========================================
+ Hits 8662 8680 +18
Misses 7154 7154
- Partials 648 649 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good but I don't like the extra wrapper on the NodeQuerier
interface
Can we add a make command and [or] some doc on how to manage/update/create mocks using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Fede and I talked through the changes. Hence dismissing the review.
Please disregard the previous unrelated PR - was supposed to be an issue in a different repo. |
Closes: #4543
docs/
)clog add [section] [stanza] [message]
Files changed
in the github PR explorerFor Admin Use: