Module accounts #4252
Closed
Module accounts #4252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
which other modules should implement a module account ? @rigelrozanski @alexanderbez @alessio |
alessio
reviewed
May 2, 2019
alessio
reviewed
May 2, 2019
alexanderbez
suggested changes
May 2, 2019
Codecov Report
@@ Coverage Diff @@
## master #4252 +/- ##
=========================================
- Coverage 58.91% 58.81% -0.1%
=========================================
Files 215 215
Lines 14482 14533 +51
=========================================
+ Hits 8532 8548 +16
- Misses 5310 5345 +35
Partials 640 640 |
Co-Authored-By: fedekunze <31522760+fedekunze@users.noreply.github.com>
alessio
reviewed
May 2, 2019
| @@ -88,8 +88,12 @@ type GenesisAccount struct { | |||
| DelegatedVesting sdk.Coins `json:"delegated_vesting"` // delegated vesting coins at time of delegation | |||
| StartTime int64 `json:"start_time"` // vesting start time (UNIX Epoch time) | |||
| EndTime int64 `json:"end_time"` // vesting end time (UNIX Epoch time) | |||
|
|
|||
| // module account fields | |||
| Module string `json:"module"` // name of the module | |||
There was a problem hiding this comment.
Indentation seems funky. Running gofmt -w -s cmd/gaia/app/genesis.go should do it
alessio
reviewed
May 2, 2019
alessio
reviewed
May 2, 2019
alessio
reviewed
May 2, 2019
alessio
reviewed
May 2, 2019
alessio
reviewed
May 2, 2019
alessio
reviewed
May 2, 2019
alessio
reviewed
May 2, 2019
There was a problem hiding this comment.
Excellent job! I'll test this shortly, when @alexanderbez comments are addressed this is good to go for me.
Co-Authored-By: fedekunze <31522760+fedekunze@users.noreply.github.com>
Co-Authored-By: fedekunze <31522760+fedekunze@users.noreply.github.com>
Co-Authored-By: fedekunze <31522760+fedekunze@users.noreply.github.com>
|
moved to #4255 as per our discussion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement modules accounts to hold coins on escrow. Originally part of #4210
Closes #3628
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
clog add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: