Context get op never crashes #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that requesting version <= 0 doesn't cause a runtime out of bounds dereference, with a simple validation and accompanying tests to ensure we never regress. Since GetOp allows int64, it is fair game that it should except out of range inputs, plus this is an SDK so is bound to be abused both unintentionally and intentionally. Fixes #400
Codecov Report
@@ Coverage Diff @@
## develop #423 +/- ##
===========================================
+ Coverage 47.93% 51.42% +3.48%
===========================================
Files 34 34
Lines 1548 1548
===========================================
+ Hits 742 796 +54
+ Misses 756 702 -54
Partials 50 50 |
|
@ebuchman thank you for taking over and for the merge! |
ParthDesai
pushed a commit
to ChorusOne/cosmos-sdk
that referenced
this pull request
Apr 19, 2021
nextSequenceAck belongs to a source-side end of a channel.
NoahSaso
pushed a commit
to NoahSaso/cosmos-sdk
that referenced
this pull request
Jun 15, 2023
(cherry picked from commit 02e3a0e) Co-authored-by: Nguyen Thanh Nhan <thanhnhan98qh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.