Add rewards and commission tags

[alexanderbez]

Add rewards and commission tags to their respective txs.

closes: #3850

---

• Targeted PR against correct branch (see CONTRIBUTING.md)

• Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

• Wrote tests

• Updated relevant documentation (docs/)

• Added a relevant changelog entry: sdkch add [section] [stanza] [message]

• rereviewed Files changed in the github PR explorer

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[codecov]

Codecov Report

Merging #4200 into develop will decrease coverage by 0.05%.
The diff coverage is 35%.

@@             Coverage Diff             @@
##           develop    #4200      +/-   ##
===========================================
- Coverage     60.2%   60.15%   -0.06%     
===========================================
  Files          212      212              
  Lines        15187    15188       +1     
===========================================
- Hits          9143     9136       -7     
- Misses        5415     5423       +8     
  Partials       629      629

[rfunduk]

Does this add tags to existing disbursement related transactions only? One of the main things we're looking for is how to handle/get info on the automated disbursements (when commission changes, and so on). Re: #3956

[alexanderbez]

Hey @rfunduk, this is only going to apply to new txs going forward once this feature is included in mainnet. #3956 should track the remainder of any distribution related tags.

[fedekunze]

ACK

[rfunduk]

@alexanderbez sorry by existing I mean existing transaction types. Like when the delegator specifically requests a withdrawal, as opposed to 'automated' withdrawals that currently leave no trace at all on the chain - such as when a validator changes their commission (and there are a few other cases, not all of which I believe I am aware of, which is part of the problem!).

It sounds like the answer is yes, though. Just the current transaction types are going to get these tags, and new transactions for the ones that are currently missing/leave no record will be handled separately.

[alexanderbez]

@rfunduk yes withdraw transactions will now have these tags.