Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swagger #4014

Merged
merged 6 commits into from
Apr 2, 2019
Merged

Update swagger #4014

merged 6 commits into from
Apr 2, 2019

Conversation

sabau
Copy link
Contributor

@sabau sabau commented Apr 1, 2019

Related to: #3120
Prerequisites for: #3989

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

sabau added 4 commits March 19, 2019 23:39
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
@sabau sabau marked this pull request as ready for review April 1, 2019 17:05
sabau added 2 commits April 1, 2019 19:13
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
@codecov
Copy link

codecov bot commented Apr 2, 2019

Codecov Report

Merging #4014 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4014      +/-   ##
===========================================
+ Coverage    60.01%   60.02%   +0.01%     
===========================================
  Files          212      212              
  Lines        15104    15104              
===========================================
+ Hits          9064     9066       +2     
+ Misses        5419     5417       -2     
  Partials       621      621

@alessio alessio requested a review from fedekunze April 2, 2019 12:50
@alexanderbez alexanderbez merged commit ecd2bfa into develop Apr 2, 2019
@alexanderbez alexanderbez deleted the sabau/3120-update-swagger branch April 2, 2019 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants