Implement client functionality for the community pool #3939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3939 +/- ##
===========================================
+ Coverage 60.33% 60.34% +<.01%
===========================================
Files 196 196
Lines 14488 14495 +7
===========================================
+ Hits 8742 8747 +5
- Misses 5165 5166 +1
- Partials 581 582 +1 |
|
I was proposing something similar, may I push here the tests? |
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
alexanderbez
suggested changes
Mar 20, 2019
yangyanqing
suggested changes
Mar 21, 2019
alexanderbez
approved these changes
Mar 21, 2019
alessio
suggested changes
Mar 22, 2019
There was a problem hiding this comment.
This addition affects the REST API as well. @jackzampolin can you update the REST docs and add an additional changelog entry under both features/gaiarest and features/gaiacli please?
|
@jackzampolin why'd delete the PR checkboxes ;) |
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| cliCtx := context.NewCLIContext().WithCodec(cdc) | ||
|
|
||
| res, err := cliCtx.QueryWithData(fmt.Sprintf("custom/%s/community_pool", queryRoute), nil) |
There was a problem hiding this comment.
it's weird that in CLI queries we sometimes use routes and sometimes the key (with cliCtx.QueryStore()
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
- Add new route to swagger.yaml - Add community pool command to docs - added pending changes Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
alessio
reviewed
Mar 27, 2019
alessio
approved these changes
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3937