Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Return an empty TxResponse #3624

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Feb 12, 2019

closes: #3585


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Sorry, something went wrong.

@codecov
Copy link

codecov bot commented Feb 12, 2019

Codecov Report

Merging #3624 into develop will decrease coverage by 0.04%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #3624      +/-   ##
===========================================
- Coverage     61.3%   61.26%   -0.05%     
===========================================
  Files          186      186              
  Lines        13992    13998       +6     
===========================================
- Hits          8578     8576       -2     
- Misses        4870     4878       +8     
  Partials       544      544

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cwgoes cwgoes merged commit 22bdc17 into develop Feb 12, 2019
@cwgoes cwgoes deleted the bez/3585-fix-tx-result-output branch February 12, 2019 16:23
@alexanderbez alexanderbez mentioned this pull request Feb 13, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SIGSEGV when sync transaction doesn't complete before timeout
3 participants