Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Fix setting tx hash when nil #3591

Merged
merged 2 commits into from
Feb 11, 2019
Merged

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Feb 10, 2019

closes: #3585


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@codecov
Copy link

codecov bot commented Feb 10, 2019

Codecov Report

Merging #3591 into develop will increase coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           develop   #3591      +/-   ##
==========================================
+ Coverage    61.47%   61.5%   +0.02%     
==========================================
  Files          186     186              
  Lines        13978   13981       +3     
==========================================
+ Hits          8593    8599       +6     
+ Misses        4838    4835       -3     
  Partials       547     547

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@cwgoes cwgoes merged commit 1d4bb1a into develop Feb 11, 2019
@cwgoes cwgoes deleted the bez/3585-fix-tx-resp-output branch February 11, 2019 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SIGSEGV when sync transaction doesn't complete before timeout
3 participants