Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Remove KV marshalling split #3230

Merged
merged 4 commits into from
Jan 7, 2019
Merged

Conversation

rigelrozanski
Copy link
Contributor

@rigelrozanski rigelrozanski commented Jan 4, 2019

closes #3233

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@rigelrozanski rigelrozanski added C:x/staking wip T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). labels Jan 4, 2019
@jackzampolin
Copy link
Member

@rigelrozanski can you link to an issue that describes this work, or summarize it in the PR description please?

@alexanderbez
Copy link
Contributor

+79 −323 ❤️

@rigelrozanski
Copy link
Contributor Author

@jackzampolin yeah I'm going to dig up the issue or create one if it doesn't exist - this issue had been fleshed out in several sdk team discussions to date - also is prerequisite to making #1402 a simpler implementation.

@jackzampolin
Copy link
Member

Thank you @rigelrozanski !

@rigelrozanski rigelrozanski force-pushed the rigel/revert-KV-seperation branch from 1476a48 to dff6681 Compare January 5, 2019 03:23
@codecov
Copy link

codecov bot commented Jan 5, 2019

Codecov Report

Merging #3230 into develop will decrease coverage by 0.01%.
The diff coverage is 81.81%.

@@             Coverage Diff             @@
##           develop    #3230      +/-   ##
===========================================
- Coverage    54.88%   54.86%   -0.02%     
===========================================
  Files          133      133              
  Lines         9555     9552       -3     
===========================================
- Hits          5244     5241       -3     
  Misses        3989     3989              
  Partials       322      322

@rigelrozanski rigelrozanski changed the title WIP: Remove KV marshalling split R4R: Remove KV marshalling split Jan 5, 2019
Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good looking refactor and cleanup. Working for me and removes a bunch of code!

@rigelrozanski rigelrozanski merged commit 20f6ff3 into develop Jan 7, 2019
@rigelrozanski rigelrozanski deleted the rigel/revert-KV-seperation branch January 7, 2019 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/staking T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove separation of key fields from value during marshalling
3 participants