-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: Remove KV marshalling split #3230
Conversation
@rigelrozanski can you link to an issue that describes this work, or summarize it in the PR description please? |
|
@jackzampolin yeah I'm going to dig up the issue or create one if it doesn't exist - this issue had been fleshed out in several sdk team discussions to date - also is prerequisite to making #1402 a simpler implementation. |
Thank you @rigelrozanski ! |
1476a48
to
dff6681
Compare
Codecov Report
@@ Coverage Diff @@
## develop #3230 +/- ##
===========================================
- Coverage 54.88% 54.86% -0.02%
===========================================
Files 133 133
Lines 9555 9552 -3
===========================================
- Hits 5244 5241 -3
Misses 3989 3989
Partials 322 322 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good looking refactor and cleanup. Working for me and removes a bunch of code!
closes #3233
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added entries in
PENDING.md
with issue #rereviewed
Files changed
in the github PR explorerFor Admin Use: