-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: Change swagger host for online API requests #3229
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3229 +/- ##
===========================================
- Coverage 54.86% 54.85% -0.02%
===========================================
Files 133 133
Lines 9554 9556 +2
===========================================
Hits 5242 5242
- Misses 3990 3992 +2
Partials 322 322 |
I don't know if we want to expose a service on a domain not controlled by the company for this. cc @greg-szabo @mircea-c |
I can change it to the voyager node, would that be better ? |
That would be better... |
We should not expose a service on a URL we don't control. That would fail any security audit. Voyager node works. |
@mircea-c do you have a specific host we can use or does |
@alexanderbez that host is the Voyager node. It works for me 😸 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Closes #2948
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added entries in
PENDING.md
with issue #rereviewed
Files changed
in the github PR explorerFor Admin Use: