-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(store/v2): remove auto migration #23380
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
96d9d1e
to
e0251f6
Compare
3eec34a
to
6f118d5
Compare
@@ -111,3 +114,13 @@ func (a *App[T]) Close() error { | |||
func (a *App[T]) GetApp() *App[T] { | |||
return a | |||
} | |||
|
|||
// SetStoreKeys sets the store keys. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove this getter and replace by appBuilder.app.storeKeys = storeBuilder.GetStoreKeys()
where it is used? not one should ever call this, so let's make it impossible.
Description
After speaking with some users, it was discovered that state sync is fairly unstable and sometimes takes hours upon hours. In testing exporting and importing osmsis lateset state it took 30-40 minutes. The manual step allows people to know when they migrated and how to handle it.
The potenital flow is that a database is migrated on a non validating node, then the db is copied over to the validating node. the node operator would replace the existing db with the one they copied/downloaded from the non validating node. This way there is minmal resource consumption on the validating node to replace it and allows less issues to arise.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...