fix(schema): fix make lint-fix reports error

[caseylove]

Description

Fixes the error reported by running make lint-fix

appdata/mux.go:142:23: G601: Implicit memory aliasing in for loop. (gosec)
                        err := batch.apply(&listener)
                                           ^
linting module cosmossdk.io/schema/testing [2025-01-14T08:44:51+00:00]

Summary by CodeRabbit

• Refactor
  • Improved internal listener handling mechanism in the application's event processing logic
  • Optimized slice iteration method to ensure accurate listener referencing

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes in the schema/appdata/mux.go file focus on modifying the ListenerMux function's implementation. Specifically, the modification involves changing how the listeners slice is accessed within the onBatch function. The update transitions from using a range loop variable to an index-based access method, potentially addressing potential issues with variable referencing during iteration.

Changes

File	Change Summary
schema/appdata/mux.go	Modified ListenerMux function to use index-based slice access instead of range loop variable in onBatch method

Suggested Labels

C:schema

Suggested Reviewers

• kocubinski
• testinginprod
• aaronc
• julienrbrt
• tac0turtle

---

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b4e88cc and a9e40bb.

📒 Files selected for processing (1)

• schema/appdata/mux.go (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

schema/appdata/mux.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

⏰ Context from checks skipped due to timeout of 90000ms (13)

• GitHub Check: tests (03)
• GitHub Check: tests (02)
• GitHub Check: tests (01)
• GitHub Check: tests (00)
• GitHub Check: test-sim-nondeterminism
• GitHub Check: test-simapp-v2
• GitHub Check: test-integration
• GitHub Check: test-system-v2
• GitHub Check: build (arm64)
• GitHub Check: build (amd64)
• GitHub Check: Analyze
• GitHub Check: golangci-lint
• GitHub Check: Summary

🔇 Additional comments (1)

schema/appdata/mux.go (1)

141-142: LGTM! The fix properly addresses the implicit memory aliasing issue.

The change from range-based to index-based iteration eliminates the G601 linting error by ensuring that we're taking the address of the actual array element rather than the loop variable, which could lead to memory aliasing issues.

For additional context: The original code likely used for _, listener := range listeners and passed &listener to batch.apply, which would have caused all iterations to reference the same memory location. The current implementation correctly references each distinct listener in the slice.

Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.