chore: use TxBody instead of the deprecated TxBodyCompat

[hoank101]

Description

Closes: #XXXX

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title, you can find examples of the prefixes below:
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• Improvement
  • Enhanced transaction body construction logic to use updated TxBody structure
  • Improved handling of extension options and transaction metadata
  • Ensured consistent transaction body creation across different scenarios

The changes optimize the transaction processing mechanism with more standardized and robust implementation.

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request modifies the getTx method in the x/auth/tx/builder.go file, specifically changing how transaction bodies are constructed. The primary change involves using txv1beta1.TxBody with enhanced capabilities, including explicit handling of TimeoutTimestamp and Unordered fields. The new implementation ensures a more standardized approach to transaction body creation, utilizing intoAnyV2 for extension options conversion and maintaining consistent error handling.

Changes

File	Change Summary
x/auth/tx/builder.go	Modified getTx method to use txv1beta1.TxBody with improved transaction body construction logic

Possibly related PRs

• fix: marshal old tx body if unordered not used #22723: Addresses compatibility issues with transaction body handling for unordered flag
• chore(x/auth): use cosmossdk.io/core/codec instead of github.com/cosmos/cosmos-sdk/codec #23273: Updates codec usage in x/auth/tx/builder.go

Suggested labels

C:server/v2

Suggested reviewers

• tac0turtle
• julienrbrt
• testinginprod

Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

x/auth/tx/builder.go (2)

120-123: Simplify the conditional check for timeoutTimestamp

The condition (w.timeoutTimestamp.IsZero() || w.timeoutTimestamp.Unix() == 0) is redundant because w.timeoutTimestamp.IsZero() is sufficient to check for a zero time.Time value. Simplifying the condition improves code readability.

Update the condition to:

if !w.unordered && w.timeoutTimestamp.IsZero() {

---

Line range hint 120-131: Reduce code duplication when constructing TxBody

Both branches of the conditional assign to body with mostly identical fields. To enhance maintainability and readability, consider constructing TxBody once and then setting the conditional fields separately.

Refactor the code as follows:

body := &txv1beta1.TxBody{
    Messages:                    anyMsgs,
    Memo:                        w.memo,
    TimeoutHeight:               w.timeoutHeight,
    ExtensionOptions:            intoAnyV2(w.extensionOptions),
    NonCriticalExtensionOptions: intoAnyV2(w.nonCriticalExtensionOptions),
}

if !w.timeoutTimestamp.IsZero() && w.timeoutTimestamp.Unix() != 0 {
    body.TimeoutTimestamp = timestamppb.New(w.timeoutTimestamp)
}

if w.unordered {
    body.Unordered = w.unordered
}

📜 Review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9ca815c and 073ca57.

📒 Files selected for processing (1)

• x/auth/tx/builder.go (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

x/auth/tx/builder.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: test-system-v2
• GitHub Check: Analyze
• GitHub Check: Summary

[julienrbrt]

This has been introduced on purpose in #22723 to keep txs created in v0.52 work with previous versions.