Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default comet port #23343

Merged
merged 4 commits into from
Jan 13, 2025
Merged

fix: default comet port #23343

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ef3fb29
fix default comet port
tac0turtle Jan 13, 2025
93d6af1
actual fix
tac0turtle Jan 13, 2025
766d0c2
Merge branch 'main' into marko/23329
Jan 13, 2025
7fe64f5
Merge branch 'main' into marko/23329
julienrbrt Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/v2/cometbft/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ func DefaultAppTomlConfig() *AppTomlConfig {
MinRetainBlocks: 0,
HaltHeight: 0,
HaltTime: 0,
Address: "tcp://127.0.0.1:26658",
Address: "tcp://127.0.0.1:26656",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Breaking Change: Default RPC server port has changed.

Changing the default port from 26658 to 26656 is a breaking change that might affect systems relying on the previous default configuration. This should be documented in the changelog.

Please ensure to:

  1. Add a breaking change entry to the CHANGELOG.md
  2. Consider adding a migration guide for users

Transport: "socket",
Trace: false,
Standalone: false,
Expand Down
Loading