fix(simapp/v2): correctly wire client/v2, clean-up api client/v2

[julienrbrt]

Description

Closes: #23305

Client/v2 wasn't properly wired, we should always have a full appoptions when enhancing the root command.

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title, you can find examples of the prefixes below:
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• Refactor

  • Removed NewAppOptionsFromConfig function from the client/v2 module
  • Simplified autocli configuration in the simapp root command
  • Removed unused address codec type and methods

• Changelog

  • Updated changelog to reflect the removal of the NewAppOptionsFromConfig function

The changes streamline the codebase by eliminating unnecessary functions and simplifying configuration processes, potentially improving overall code maintainability.

[coderabbitai]

Warning

Rate limit exceeded

@julienrbrt has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 57 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between abb7a03 and 5b92f68.

📒 Files selected for processing (1)

• client/v2/go.mod (1 hunks)

📝 Walkthrough

Walkthrough

The pull request involves removing the NewAppOptionsFromConfig function from the client/v2/autocli/app.go file. This change simplifies the codebase by eliminating an unused function related to application options initialization. The modification affects the simapp/v2/simdv2/cmd/root.go file, which now uses a more direct approach for initializing autocli options through dependency injection. The changelog has been updated to reflect this removal.

Changes

File	Change Summary
client/v2/CHANGELOG.md	Added entry documenting removal of NewAppOptionsFromConfig function
client/v2/autocli/app.go	- Removed NewAppOptionsFromConfig function - Deleted nopAddressCodec type and its methods - Removed related import statements
simapp/v2/simdv2/cmd/root.go	- Removed nodeservice.NewNodeCommands() - Simplified autocli options initialization - Removed autoCLIModuleOpts map

Assessment against linked issues

Objective	Addressed	Explanation
Fix panic when querying gov proposals by depositor [#23305]	❓	Unable to definitively confirm resolution without further testing

Possibly related PRs

• refactor(simdv2): allow non-comet server components #22351: Directly related to removal of NewAppOptionsFromConfig function
• docs(simapp): update CHANGELOG to proper version #22739: Potential changelog updates for SimApp
• test(systemtests): fix gRPC tests for v1 & v2 #22774: gRPC test fixes that may impact application structure
• chore: prepare v2 beta (3/3) #23034: Preparation for v2 beta release

Suggested labels

C:Confix, C:server/v2

Suggested reviewers

• akhilkumarpilli
• facundomedica

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[aljo242]

LGTM - just need to run the tidy script