R4R: simulation: reduce number of failed governance msgs #2299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2299 +/- ##
========================================
Coverage 63.87% 63.87%
========================================
Files 140 140
Lines 8682 8682
========================================
Hits 5546 5546
Misses 2756 2756
Partials 380 380 |
cwgoes
approved these changes
Sep 12, 2018
|
What is blocking a merge? |
Was just wanting to preserve failing simulations, but since we're implementing #2312 that doesn't matter. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR basically makes the simulator not schedule a ton of votes for proposals that fail (due to the validator not having enough money left).
On
make test_sim_gaia_fastBefore:
after
Fixing the remaining failing votes seems a bit more complicated, as we have to ensure the proposal has enough money before those votes. We could perhaps schedule deposits as well, but I'll save that for a future PR.
No changelog entry needed.
For Admin Use: