Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checked error on Fprintf #2257

Merged
merged 1 commit into from
Sep 7, 2018
Merged

checked error on Fprintf #2257

merged 1 commit into from
Sep 7, 2018

Conversation

sunnya97
Copy link
Member

@sunnya97 sunnya97 commented Sep 7, 2018

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Sep 7, 2018

Codecov Report

Merging #2257 into develop will decrease coverage by 0.02%.
The diff coverage is 33.33%.

@@             Coverage Diff             @@
##           develop    #2257      +/-   ##
===========================================
- Coverage    63.98%   63.95%   -0.03%     
===========================================
  Files          140      140              
  Lines         8608     8612       +4     
===========================================
  Hits          5508     5508              
- Misses        2723     2725       +2     
- Partials       377      379       +2

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@cwgoes cwgoes merged commit 5e13b2b into develop Sep 7, 2018
@cwgoes cwgoes deleted the sunny/fix-develop-lint branch September 7, 2018 06:34
@alexanderbez alexanderbez mentioned this pull request Sep 7, 2018
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants