-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump rocksdb & core & update ci codeowners #21652
Merged
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
78e3855
build(deps): bump rocksdb
julienrbrt 841b634
typo
julienrbrt 9498700
updates
julienrbrt 72cf359
Merge branch 'main' into julien/rocksdb
julienrbrt f2ed4c4
Merge branch 'main' into julien/rocksdb
julienrbrt bcfbc40
codeowners
julienrbrt a66222d
bump core
julienrbrt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,7 +10,7 @@ permissions: | |
contents: read | ||
|
||
env: | ||
ROCKSDB_VERSION: 8.11.3 | ||
ROCKSDB_VERSION: 9.6.1 | ||
|
||
jobs: | ||
golangci: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tip
Codebase Verification
The update to
github.com/dgraph-io/ristretto
to commitc67e07994f91
does not appear necessary for functional reasons.The commit only updates the
CODEOWNERS
file, which does not affect the functionality of the code. Consider reverting to a stable release version unless there is a specific reason for this update.Analysis chain
Verify the reason for updating
github.com/dgraph-io/ristretto
to a specific commit.Updating to the commit hash
c67e07994f91
suggests a need for a specific version, potentially to fix a critical issue.Ensure that there is a valid reason for this update and that it does not introduce any unintended side effects by running the following script:
Also, review the commit history and release notes to understand the reason for updating to this specific commit.
Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 45
Script:
Length of output: 563