Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local testnet as a (docker-compose) daemon #2028

Closed
wants to merge 1 commit into from

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Aug 14, 2018

Run a local testnet (via docker compose) as a daemon.

Note, you can already get/tail logs via:

  • docker logs -f <container-name>
  • Manually inspect the file(s) (e.g. ./build/node0/gaiad/${LOG:-gaiad.log})

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Updated all relevant documentation (docs/)
  • Updated all relevant code comments
  • Wrote tests
  • Added entries in PENDING.md that include links to the relevant issue or PR that most accurately describes the change.
  • Updated cmd/gaia and examples/

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Aug 14, 2018

Codecov Report

Merging #2028 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2028   +/-   ##
========================================
  Coverage    64.86%   64.86%           
========================================
  Files          115      115           
  Lines         6862     6862           
========================================
  Hits          4451     4451           
  Misses        2127     2127           
  Partials       284      284

Copy link
Contributor

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I know Jack wanted this as well

@alexanderbez alexanderbez requested review from jackzampolin and removed request for ebuchman August 14, 2018 18:48
@jackzampolin
Copy link
Member

I like this! 👍

@jackzampolin
Copy link
Member

Can we hold off on this one please? I've had to make the same change in #2018 so this would be redundant.

@alexanderbez
Copy link
Contributor Author

@jackzampolin sure. You can close this PR. Looks like #2018 needs a good rebase though

@cwgoes
Copy link
Contributor

cwgoes commented Aug 15, 2018

Closing in favor of #2018.

@cwgoes cwgoes closed this Aug 15, 2018
@cwgoes cwgoes deleted the bez/local-testnet-daemonize branch August 15, 2018 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants