Code

refactor: remove defer in loop#20223

Code

Merged

tac0turtle merged 29 commits intocosmos:maincosmos/cosmos-sdk:mainfrom notional-labs:refactor-defernotional-labs/cosmos-sdk:refactor-deferCopy head branch name to clipboardMay 29, 2024

+70-43

Commits

Commits on Apr 30, 2024

• refactor defer in loop, and add error handling for Close function

  tuantran1702

  committed
  248ad76

  Copy full SHA for 248ad76

• Update store/storage/storage_test_suite.go

  Show description for 306cf5b
  

  tuantran1702

  and

  coderabbitai[bot]

  authored
  306cf5b

  Copy full SHA for 306cf5b

• Update x/group/keeper/invariants.go

  Show description for 7b0116e
  

  tuantran1702

  and

  coderabbitai[bot]

  authored
  7b0116e

  Copy full SHA for 7b0116e

• Update store/commitment/store.go

  Show description for e45b71f
  

  tuantran1702

  and

  coderabbitai[bot]

  authored
  e45b71f

  Copy full SHA for e45b71f

• Update store/commitment/store.go

  Show description for 023247e
  

  tuantran1702

  and

  coderabbitai[bot]

  authored
  023247e

  Copy full SHA for 023247e

• Update store/migration/manager.go

  Show description for 93c36dc
  

  tuantran1702

  and

  coderabbitai[bot]

  authored
  93c36dc

  Copy full SHA for 93c36dc

Commits on May 1, 2024

• refactor to use anonymous closure

  tuantran1702

  committed
  b0c99b4

  Copy full SHA for b0c99b4

• Merge branch 'refactor-defer' of github.com:notional-labs/cosmos-sdk into refactor-defer

  tuantran1702

  committed
  badd9c5

  Copy full SHA for badd9c5

• linting

  tuantran1702

  committed
  9995356

  Copy full SHA for 9995356

• rollback importer defer, bring pw.Close() to closure

  tuantran1702

  committed
  b6c8dbe

  Copy full SHA for b6c8dbe

• remove incorrect Close()

  tuantran1702

  committed
  097384b

  Copy full SHA for 097384b

Commits on May 2, 2024

• refactor

  tuantran1702

  committed
  e7b1a17

  Copy full SHA for e7b1a17

• fix redundant err check

  tuantran1702

  committed
  b6a63be

  Copy full SHA for b6a63be

Commits on May 9, 2024

• refactor defer in loop, and add error handling for Close function

  tuantran1702

  committed
  95fc4a7

  Copy full SHA for 95fc4a7

• refactor to use anonymous closure

  tuantran1702

  committed
  869ec3e

  Copy full SHA for 869ec3e

• Update store/storage/storage_test_suite.go

  Show description for d819ddd
  

  tuantran1702

  and

  coderabbitai[bot]

  committed
  d819ddd

  Copy full SHA for d819ddd

• Update store/commitment/store.go

  Show description for 4543e67
  

  tuantran1702

  and

  coderabbitai[bot]

  committed
  4543e67

  Copy full SHA for 4543e67

• Update store/commitment/store.go

  Show description for fce217a
  

  tuantran1702

  and

  coderabbitai[bot]

  committed
  fce217a

  Copy full SHA for fce217a

• linting

  tuantran1702

  committed
  fbaef03

  Copy full SHA for fbaef03

• rollback importer defer, bring pw.Close() to closure

  tuantran1702

  committed
  953cfac

  Copy full SHA for 953cfac

• remove incorrect Close()

  tuantran1702

  committed
  879999d

  Copy full SHA for 879999d

• refactor

  tuantran1702

  committed
  e9df29b

  Copy full SHA for e9df29b

• fix redundant err check

  tuantran1702

  committed
  8701127

  Copy full SHA for 8701127

• add missing import

  tuantran1702

  committed
  0415482

  Copy full SHA for 0415482

• add err handling

  tuantran1702

  committed
  a737df0

  Copy full SHA for a737df0

Commits on May 11, 2024

• Merge branch 'main' into refactor-defer

  tuantran1702

  authored
  2f0ac3f

  Copy full SHA for 2f0ac3f

• Merge branch 'refactor-defer' of github.com:notional-labs/cosmos-sdk into refactor-defer

  tuantran1702

  committed
  5bc9597

  Copy full SHA for 5bc9597

Commits on May 17, 2024

• Merge branch 'main' into refactor-defer

  tuantran1702

  authored
  076a43f

  Copy full SHA for 076a43f

• lint errorf

  tuantran1702

  committed
  101706b

  Copy full SHA for 101706b