Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Must specify amount flag #1841

Merged
merged 3 commits into from
Jul 26, 2018
Merged

Must specify amount flag #1841

merged 3 commits into from
Jul 26, 2018

Conversation

AdityaSripal
Copy link
Member

@AdityaSripal AdityaSripal commented Jul 26, 2018 •
edited
Loading

Addresses #1828

  • Linked to github-issue with discussion and accepted design
  • Updated all relevant documentation (docs/)
  • Updated all relevant code comments
  • Wrote tests
  • Added entries in PENDING.md
  • Updated cmd/gaia and examples/

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@AdityaSripal AdityaSripal changed the title Aditya/amount fix Must specify amount flag Jul 26, 2018
@codecov
Copy link

codecov bot commented Jul 26, 2018 •
edited
Loading

Codecov Report

Merging #1841 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1841   +/-   ##
========================================
  Coverage    63.42%   63.42%           
========================================
  Files          117      117           
  Lines         6940     6940           
========================================
  Hits          4402     4402           
  Misses        2283     2283           
  Partials       255      255

alexanderbez
alexanderbez approved these changes Jul 26, 2018
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 👌

ValarDragon
ValarDragon approved these changes Jul 26, 2018
View reviewed changes
Copy link
Contributor

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cwgoes
cwgoes approved these changes Jul 26, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@cwgoes cwgoes merged commit 74e06d8 into develop Jul 26, 2018
@cwgoes cwgoes deleted the aditya/amount-fix branch July 26, 2018 21:41
@cwgoes cwgoes mentioned this pull request Jul 26, 2018
Closed
4 tasks
@rigelrozanski
Copy link
Contributor

@AdityaSripal if you want the PR to close the issue you must use special keywords, Addresses happens to not be on the list: (closes, fixes, etc) . https://help.github.com/articles/closing-issues-using-keywords/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes approved these changes

@ValarDragon ValarDragon ValarDragon approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
C:CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AdityaSripal @rigelrozanski @alexanderbez @ValarDragon @cwgoes