Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: wrong autocli description #18120

Merged
merged 8 commits into from
Oct 16, 2023
Merged

Conversation

julienrbrt
Copy link
Member

Description

This PR makes me re-check every autocli options and backport the one compatible with v0.50: #18111

This made me see some description issues in some autocli config


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt marked this pull request as ready for review October 16, 2023 08:45
@julienrbrt julienrbrt requested a review from a team as a code owner October 16, 2023 08:45
@github-prbot github-prbot requested review from a team, kocubinski and atheeshp and removed request for a team October 16, 2023 08:45
@julienrbrt julienrbrt requested review from a team and facundomedica and removed request for kocubinski and a team October 16, 2023 08:45
@julienrbrt julienrbrt changed the title docs: wrong autocli description refactor: wrong autocli description Oct 16, 2023
@julienrbrt julienrbrt enabled auto-merge October 16, 2023 09:17
Merged via the queue into main with commit 3747519 Oct 16, 2023
@julienrbrt julienrbrt deleted the julien/wrong-autocli-desc branch October 16, 2023 09:56
julienrbrt added a commit that referenced this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants