feat(x/distribution): add autocli config query #16218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
julienrbrt
reviewed
May 26, 2023
julienrbrt
requested changes
Jun 6, 2023
julienrbrt
reviewed
Jun 9, 2023
facundomedica
approved these changes
Jun 12, 2023
|
There are still some tests failing if I look at CI. |
fixed! |
julienrbrt
reviewed
Jun 15, 2023
julienrbrt
approved these changes
Jun 15, 2023
x/distribution/autocli.go
Outdated
| if err != nil { | ||
| panic(err) | ||
| } | ||
| valAddress, err := types.ValAddressFromHex("A58856F0FD53BF058B4909A21AEC019107BA6A58856F0FD53BF058B4909A21AEC019107BA6") |
There was a problem hiding this comment.
This does not give me a good address in an example
simd query distribution slashes cosmosvaloper15ky9du8a2wlstz6fpx3p4mqpjyrm56jcs4hsl4fm7pvtfyy6yxhvqxgs0wnqmanre8 0 100
Maybe let's just simplify the ux and in the example just say [validator address]. That will clean-up some dependency as well.
julienrbrt
reviewed
Jun 15, 2023
CHANGELOG.md
Outdated
| @@ -37,6 +37,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
| # Changelog | |||
|
|
|||
| ## [Unreleased] | |||
| * (x/distriubtion) [#16218](https://github.com/cosmos/cosmos-sdk/pull/16218) Add Autocli config to distribution module. | |||
There was a problem hiding this comment.
nit, can it be under the improvement category?
mergify bot
pushed a commit
that referenced
this pull request
Jun 16, 2023
(cherry picked from commit 6f32a94)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #16214
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change