Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(collections): add NewSchemaBuilderFromAccessor function #15271

Merged
merged 3 commits into from
Mar 6, 2023

Conversation

testinginprod
Copy link
Contributor

@testinginprod testinginprod commented Mar 6, 2023

Description

Adds a NewSchemaBuilderFromAccessor function.
Also removes the dependency on multierror, since golang 1.20 allows multi-err wrapping.

closes: #15272


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@testinginprod testinginprod requested a review from a team as a code owner March 6, 2023 16:19
@github-prbot github-prbot requested review from a team, facundomedica and tac0turtle and removed request for a team March 6, 2023 16:20
@testinginprod testinginprod changed the title collections: add NewSchemaBuilderFromAccessor function feat(collections): add NewSchemaBuilderFromAccessor function Mar 6, 2023
@testinginprod testinginprod enabled auto-merge (squash) March 6, 2023 16:27
@testinginprod testinginprod merged commit 3b40a62 into main Mar 6, 2023
@testinginprod testinginprod deleted the tip/collections_sb branch March 6, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

collections: add a *SchemaBuilder constructor that uses a store accessor function
3 participants