Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add config iavl-lazy-loading to enable lazy loading of iavl store (backport #14189) #14863

Merged
merged 4 commits into from
Feb 1, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 1, 2023

This is an automatic backport of pull request #14189 done by Mergify.
Cherry-pick of b266522 has failed:

On branch mergify/bp/release/v0.47.x/pr-14189
Your branch is up to date with 'origin/release/v0.47.x'.

You are currently cherry-picking commit b266522c8.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   baseapp/options.go
	modified:   server/config/config.go
	modified:   server/config/toml.go
	modified:   server/mock/store.go
	modified:   server/start.go
	modified:   server/util.go
	modified:   store/iavl/store.go
	modified:   store/iavl/tree.go
	modified:   store/rootmulti/store.go
	modified:   store/types/store.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   CHANGELOG.md
	both modified:   go.mod
	both modified:   go.sum
	both modified:   simapp/go.mod
	both modified:   simapp/go.sum
	deleted by us:   store/go.mod
	deleted by us:   store/go.sum
	both modified:   tests/go.mod
	both modified:   tests/go.sum
	deleted by us:   x/nft/go.mod
	deleted by us:   x/nft/go.sum
	deleted by us:   x/upgrade/go.mod
	deleted by us:   x/upgrade/go.sum

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

…tore (#14189)

Co-authored-by: Marko <marbar3778@yahoo.com>
(cherry picked from commit b266522)

# Conflicts:
#	CHANGELOG.md
#	go.mod
#	go.sum
#	simapp/go.mod
#	simapp/go.sum
#	store/go.mod
#	store/go.sum
#	tests/go.mod
#	tests/go.sum
#	x/nft/go.mod
#	x/nft/go.sum
#	x/upgrade/go.mod
#	x/upgrade/go.sum
@@ -39,6 +39,7 @@ Ref: https://keepachangelog.com/en/1.0.0/

### Improvements

* (store) [#14410](https://github.com/cosmos/cosmos-sdk/pull/14410) `rootmulti.Store.loadVersion` has validation to check if all the module stores' height is correct, it will error if any module store has incorrect height.
* (store) [#14189](https://github.com/cosmos/cosmos-sdk/pull/14189) Add config `iavl-lazy-loading` to enable lazy loading of iavl store, to improve start up time of archive nodes, add method `SetLazyLoading` to `CommitMultiStore` interface.
Copy link
Member

@julienrbrt julienrbrt Feb 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a remark about what to add in the app.toml like in v0.46?

I still need to focus back on #14630 so the following it won't be as important anymore, but https://github.com/cosmos/cosmos-sdk/blob/main/tools/confix/data/ should be updated with the new field as well (on main).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean by updated?

Copy link
Member

@julienrbrt julienrbrt Feb 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, explaining here: #14876

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@julienrbrt julienrbrt merged commit 3a1c797 into release/v0.47.x Feb 1, 2023
@julienrbrt julienrbrt deleted the mergify/bp/release/v0.47.x/pr-14189 branch February 1, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants