Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autocli): add simple msg support #14832

Merged
merged 80 commits into from
Mar 2, 2023

Conversation

JeancarloBarrios
Copy link
Contributor

Description

Closes: #13284


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:CLI label Jan 30, 2023
Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there's a way we can reuse some of the code for building queries a bit more. Looks like the logic is pretty similar. Maybe with some shared functions with a couple of function parameters for the places that differ?

@JeancarloBarrios
Copy link
Contributor Author

like the logic is pretty similar. Maybe with some shared functions with a couple of function parameters for the places that differ?

Sure I agree!

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks good, is this already plugged into hubl?

@julienrbrt
Copy link
Member

Reviewing this promptly. Sorry for the delay!

Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like CI is passing now. Let's merge and keep iterating. Looks like hubl integration needs to be added separately. We can do that in a follow up

@JeancarloBarrios JeancarloBarrios added the A:automerge Automatically merge PR once all prerequisites pass. label Mar 2, 2023
@JeancarloBarrios JeancarloBarrios merged commit ee458eb into main Mar 2, 2023
@JeancarloBarrios JeancarloBarrios deleted the JeancarloBarrios/add-simple-msg-support branch March 2, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutoCLI basic Msg support
6 participants