-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autocli): add simple msg support #14832
feat(autocli): add simple msg support #14832
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if there's a way we can reuse some of the code for building queries a bit more. Looks like the logic is pretty similar. Maybe with some shared functions with a couple of function parameters for the places that differ?
Sure I agree! |
…cosmos/cosmos-sdk into JeancarloBarrios/add-simple-msg-support
…cosmos/cosmos-sdk into JeancarloBarrios/add-simple-msg-support
…cosmos/cosmos-sdk into JeancarloBarrios/add-simple-msg-support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally looks good, is this already plugged into hubl?
…cosmos/cosmos-sdk into JeancarloBarrios/add-simple-msg-support
Reviewing this promptly. Sorry for the delay! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like CI is passing now. Let's merge and keep iterating. Looks like hubl integration needs to be added separately. We can do that in a follow up
Description
Closes: #13284
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change