test: add more secp256k1 test vectors

[JulianToledano]

Description

Closes:
#11343

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[tac0turtle]

Would like @ValarDragon to sign off before merge

[ValarDragon]

How are these vectors generated?

Whats something I should use to verify them? Happy to get a sage script going for it

[JulianToledano]

How are these vectors generated?

Whats something I should use to verify them? Happy to get a sage script going for it

Those were generated with secp256k1.GenPrivKey().
This is the script used:

import (
	"encoding/hex"
	"fmt"
	"github.com/cosmos/btcutil/base58"
	"github.com/cosmos/cosmos-sdk/crypto/keys/secp256k1"
)

func main() {
	priv := secp256k1.GenPrivKey()
	encPriv := make([]byte, len(priv.Key)*2)
	hex.Encode(encPriv, priv.Key)
	fmt.Println(fmt.Sprintf("PrivKey: %v", string(encPriv)))
	pub := priv.PubKey()
	encPub := make([]byte, len(pub.Bytes())*2)
	hex.Encode(encPub, pub.Bytes())
	fmt.Println(fmt.Sprintf("PubKey: %v", string(encPub)))
	addr := pub.Address()
	fmt.Println(fmt.Sprintf("Address: %v", base58.CheckEncode(addr, 0)))
}

[tac0turtle]

can we add a test or small function to do this in the code? that way if anything changes it's easy to fix it

[ValarDragon]

Hrmm, ok.

However I personally wouldn't mark the issue as closed (or would make a second issue) for test vectors then.
These test vectors are then guaranteeing this code is deterministic / hasn't changed, but not guaranteeing that it matches any other implementation.
We should add a code comment on top of every test vector (or set of vectors), explaining how it is sourced. In this case, "matches consistency against a prior version of this library"

[JulianToledano]

@ValarDragon would be enough to generate some test cases with go-ethereum? I have the following code snippet:

import (
	"crypto/ecdsa"
	"crypto/sha256"
	"encoding/hex"
	"fmt"
	"github.com/btcsuite/btcutil/base58"
	"github.com/ethereum/go-ethereum/crypto"
	"golang.org/x/crypto/ripemd160"
)

func ethereumKeys() {
	// Generate private key with the go-ethereum
	priv, err := crypto.GenerateKey()
	if err != nil {
		panic(err)
	}
	encPriv := make([]byte, len(priv.D.Bytes())*2)
	hex.Encode(encPriv, priv.D.Bytes())
	fmt.Println(fmt.Sprintf("PrivKey: %v", string(encPriv)))

	// Get go-ethereum public key
	ethPub, ok := priv.Public().(*ecdsa.PublicKey)
	if !ok {
		panic(err)
	}
	ethPublicKeyBytes := crypto.FromECDSAPub(ethPub)

	// Format byte depending on the oddness of the Y coordinate.
	format := 0x02
	if ethPub.Y.Bit(0) != 0 {
		format = 0x03
	}

	// Public key in the 33-byte compressed format.
	pub := ethPublicKeyBytes[:33]
	encPub := make([]byte, len(pub)*2)
	pub[0] = byte(format)
	hex.Encode(encPub, pub)
	fmt.Println(fmt.Sprintf("PubKey: %v", string(encPub)))

	//  Bitcoin style addresses
	sha := sha256.Sum256(pub)
	hasherRIPEMD160 := ripemd160.New()
	hasherRIPEMD160.Write(sha[:])
	addr := hasherRIPEMD160.Sum(nil)
	fmt.Println(fmt.Sprintf("Address: %v", base58.CheckEncode(addr[:], 0)))
}

[tac0turtle]

Since we can rely on go-Ethereum as a dep we should comment out the test. But seems sufficient

[JulianToledano]

go-ethereum test vectors added

[JulianToledano]

@tac0turtle did you have a chance to look at the last commit?

[tac0turtle]

yes, but we cant update the pr in order to merge. Need you to update for us to merge