-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(textual): Use HEX instead of base64 #12954
Conversation
Codecov Report
@@ Coverage Diff @@
## main #12954 +/- ##
==========================================
- Coverage 55.87% 55.62% -0.26%
==========================================
Files 646 652 +6
Lines 54895 55040 +145
==========================================
- Hits 30675 30616 -59
- Misses 21762 21952 +190
- Partials 2458 2472 +14
|
What is the behavior for long bytes fields? For a cosmwasm contract that could be quite long. What about a provision where short bytes fields (maybe <= 256 or 512) are displayed in their entirety in hex, and long fields automatically get hashed and the length + hash is displayed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: we could also consider z-base32
if we want more compact representation, preserving readability.
ref: #12910 (comment)
For now we still have bijectivity as a spec. If we do this, then we'll lose bijectivity. |
Description
ref: #12910 (comment)
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change