Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: params cleanup #12480

Merged
merged 7 commits into from
Jul 8, 2022
Merged

chore: params cleanup #12480

merged 7 commits into from
Jul 8, 2022

Conversation

alexanderbez
Copy link
Contributor

Adds missing error checks to the modules that migrated away from x/params

@alexanderbez alexanderbez requested a review from a team as a code owner July 7, 2022 16:04
@alexanderbez alexanderbez added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 7, 2022
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #12480 (2b9558f) into main (36ffd7a) will decrease coverage by 0.00%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12480      +/-   ##
==========================================
- Coverage   65.57%   65.57%   -0.01%     
==========================================
  Files         685      685              
  Lines       71635    71638       +3     
==========================================
- Hits        46977    46975       -2     
- Misses      22011    22015       +4     
- Partials     2647     2648       +1     
Impacted Files Coverage Δ
x/distribution/module.go 56.66% <ø> (ø)
x/slashing/keeper/genesis.go 74.41% <0.00%> (-4.16%) ⬇️
x/staking/module.go 66.05% <ø> (ø)
x/mint/keeper/genesis.go 40.00% <33.33%> (-10.00%) ⬇️
x/group/keeper/keeper.go 58.26% <0.00%> (-0.40%) ⬇️

@mergify mergify bot merged commit 69d8fa2 into main Jul 8, 2022
@mergify mergify bot deleted the bez/params-cleanup branch July 8, 2022 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/distribution distribution module related C:x/gov C:x/mint C:x/slashing C:x/staking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants