Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename container.AutoGroupType to container.ManyPerContainerType #11978

Merged
merged 2 commits into from
May 18, 2022

Conversation

facundomedica
Copy link
Member

@facundomedica facundomedica commented May 17, 2022

Description

Closes: #11935


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@facundomedica facundomedica requested a review from a team as a code owner May 17, 2022 13:50
@github-actions github-actions bot added the C:depinject Issues and PR related to depinject label May 17, 2022
@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #11978 (57d2b3b) into main (0b810ba) will increase coverage by 0.30%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11978      +/-   ##
==========================================
+ Coverage   66.04%   66.35%   +0.30%     
==========================================
  Files         680      691      +11     
  Lines       71548    72316     +768     
==========================================
+ Hits        47254    47982     +728     
- Misses      21590    21620      +30     
- Partials     2704     2714      +10     
Impacted Files Coverage Δ
container/group.go 83.72% <71.42%> (ø)
container/container.go 89.60% <100.00%> (ø)
store/tools/ics23/iavl/convert.go
store/tools/ics23/iavl/create.go
store/tools/ics23/smt/create.go
container/errors.go 100.00% <0.00%> (ø)
container/module_dep.go 100.00% <0.00%> (ø)
container/build.go 76.00% <0.00%> (ø)
container/provider_desc.go 100.00% <0.00%> (ø)
... and 10 more

@facundomedica
Copy link
Member Author

Tagging you for visibility @aaronc

@amaury1093 amaury1093 added A:automerge Automatically merge PR once all prerequisites pass. and removed A:automerge Automatically merge PR once all prerequisites pass. labels May 18, 2022
@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label May 18, 2022
@facundomedica facundomedica removed the A:automerge Automatically merge PR once all prerequisites pass. label May 18, 2022
@facundomedica
Copy link
Member Author

Don't merge yet, gotta double-check

@facundomedica facundomedica merged commit bc2d553 into main May 18, 2022
@facundomedica facundomedica deleted the facu/rename-autogrouptype branch May 18, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:depinject Issues and PR related to depinject
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider renaming container.AutoGroupType
5 participants