Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update query.go to include pagination for bank q totals #11355

Merged
merged 10 commits into from
Mar 15, 2022
Merged

fix: Update query.go to include pagination for bank q totals #11355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
437752e
Update query.go
okwme Mar 10, 2022
e4547c8
Update CHANGELOG.md
okwme Mar 10, 2022
b77adba
Update x/bank/client/cli/query.go
tac0turtle Mar 10, 2022
cfd6e89
Merge branch 'master' into okwme-patch-2
alexanderbez Mar 11, 2022
5fa8a84
Merge branch 'master' into okwme-patch-2
okwme Mar 11, 2022
dad3556
Merge branch 'master' into okwme-patch-2
tac0turtle Mar 11, 2022
628c080
Merge branch 'master' into okwme-patch-2
tac0turtle Mar 11, 2022
946c85f
Merge branch 'master' into okwme-patch-2
tac0turtle Mar 14, 2022
b422c57
Merge branch 'master' into okwme-patch-2
alexanderbez Mar 15, 2022
92ab40f
fix test
alexanderbez Mar 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@ Ref: https://keepachangelog.com/en/1.0.0/

### Bug Fixes

* [\#11354](https://github.com/cosmos/cosmos-sdk/pull/11355) Added missing pagination flag for `bank q total` query.
* [\#11197](https://github.com/cosmos/cosmos-sdk/pull/11197) Signing with multisig now works with multisig address which is not in the keyring.
* (makefile) [\#11285](https://github.com/cosmos/cosmos-sdk/pull/11285) Fix lint-fix make target.
* (client) [\#11283](https://github.com/cosmos/cosmos-sdk/issues/11283) Support multiple keys for tx simulation and setting automatic gas for txs.
Expand Down
1 change: 1 addition & 0 deletions x/bank/client/cli/query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,7 @@ To query for the total supply of a specific coin denomination use:

cmd.Flags().String(FlagDenom, "", "The specific balance denomination to query for")
flags.AddQueryFlagsToCmd(cmd)
flags.AddPaginationFlagsToCmd(cmd, "all supply totals")

return cmd
}
2 changes: 1 addition & 1 deletion x/bank/client/testutil/suite.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ func (s *IntegrationTestSuite) TestGetCmdQueryTotalSupply() {
sdk.NewCoin(fmt.Sprintf("%stoken", val.Moniker), s.cfg.AccountTokens),
sdk.NewCoin(s.cfg.BondDenom, s.cfg.StakingTokens.Add(sdk.NewInt(10))),
),
Pagination: &query.PageResponse{Total: 2},
Pagination: &query.PageResponse{Total: 0},
},
},
{
Expand Down