Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune PebbleDB Options #18178

Closed
Tracked by #17041
alexanderbez opened this issue Oct 19, 2023 · 7 comments · Fixed by #18195
Closed
Tracked by #17041

Tune PebbleDB Options #18178

alexanderbez opened this issue Oct 19, 2023 · 7 comments · Fixed by #18195
Assignees
Labels

Comments

@alexanderbez
Copy link
Contributor

alexanderbez commented Oct 19, 2023

We currently use default opts for PebbleDB as a SS backend in store v2.

Benchmarks show that reads are very fast but writes are pretty awful in terms of performance.

Even though SS should be read optimized, writes should not be a huge bottleneck. There are a handful of levers we should explore tuning, e.g. MemTableSize, to ensure writes are as efficient as possible.

For reference, these are the PebbleDB levers CockroachDB tunes: https://github.com/cockroachdb/cockroach/blob/master/pkg/storage/pebble.go#L602

@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Oct 19, 2023
@alexanderbez alexanderbez added C:Store WG: Storage and removed needs-triage Issue that needs to be triaged labels Oct 19, 2023
@alexanderbez
Copy link
Contributor Author

cc @Kbhat1

@tac0turtle
Copy link
Member

Are you able to post the benchmarks here?

@alexanderbez
Copy link
Contributor Author

#17504 :)

@tac0turtle
Copy link
Member

Are the results posted anywhere?

@alexanderbez
Copy link
Contributor Author

alexanderbez commented Oct 20, 2023

Are the results posted anywhere?

They're in the PR @tac0turtle: https://pastebin.com/raw/q5LhTcRy

@tac0turtle
Copy link
Member

my bad was viewing on mobile

@alexanderbez
Copy link
Contributor Author

@Kbhat1 from Sei is helping us benchmark further and find a possible set of ideal opts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants