Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR number written as Issue number in CHANGELOG for v0.46.0 #12940

Closed
taramakage opened this issue Aug 17, 2022 · 3 comments · Fixed by #12959
Closed

PR number written as Issue number in CHANGELOG for v0.46.0 #12940

taramakage opened this issue Aug 17, 2022 · 3 comments · Fixed by #12959

Comments

@taramakage
Copy link
Contributor

taramakage commented Aug 17, 2022 •
edited
Loading

See here: https://github.com/cosmos/cosmos-sdk/blob/v0.46.0/CHANGELOG.md?plain=1#L134

Modify Issue number #9407 in brackets to its PR number would be more context consistent.
@julienrbrt
Copy link
Member

Would you want to do that @taramakage?

@taramakage
Copy link
Contributor Author

Yes, I'd love to @julienrbrt

@julienrbrt
Copy link
Member

Thank you!

@taramakage taramakage mentioned this issue Aug 18, 2022
Merged
8 tasks
@mergify mergify bot closed this as completed in #12959 Aug 18, 2022
mergify bot pushed a commit that referenced this issue Aug 18, 2022
@taramakage
chore: fix pr number changelog (#12959)
a71be29 
## Description

Closes: #12940 



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed all author checklist items have been addressed
- [ ] confirmed that this PR does not change production code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fix pr number changelog
2 participants
@julienrbrt @taramakage