Skip to content

Commit

Permalink
move checks
Browse files Browse the repository at this point in the history
  • Loading branch information
alexanderbez committed Sep 3, 2020
1 parent b386ef8 commit d34ef20
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 16 deletions.
8 changes: 0 additions & 8 deletions x/auth/vesting/handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,6 @@ func handleMsgCreateVestingAccount(ctx sdk.Context, ak keeper.AccountKeeper, bk
}
}()

if err := bk.SendEnabledCoins(ctx, msg.Amount...); err != nil {
return nil, err
}

if bk.BlockedAddr(msg.ToAddress) {
return nil, sdkerrors.Wrapf(sdkerrors.ErrUnauthorized, "%s is not allowed to receive transactions", msg.ToAddress)
}

err := bk.SendCoins(ctx, msg.FromAddress, msg.ToAddress, msg.Amount)
if err != nil {
return nil, err
Expand Down
8 changes: 0 additions & 8 deletions x/bank/handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,6 @@ func NewHandler(k keeper.Keeper) sdk.Handler {

// Handle MsgSend.
func handleMsgSend(ctx sdk.Context, k keeper.Keeper, msg *types.MsgSend) (*sdk.Result, error) {
if err := k.SendEnabledCoins(ctx, msg.Amount...); err != nil {
return nil, err
}

if k.BlockedAddr(msg.ToAddress) {
return nil, sdkerrors.Wrapf(sdkerrors.ErrUnauthorized, "%s is not allowed to receive transactions", msg.ToAddress)
}

err := k.SendCoins(ctx, msg.FromAddress, msg.ToAddress, msg.Amount)
if err != nil {
return nil, err
Expand Down
8 changes: 8 additions & 0 deletions x/bank/keeper/send.go
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,14 @@ func (k BaseSendKeeper) InputOutputCoins(ctx sdk.Context, inputs []types.Input,
// SendCoins transfers amt coins from a sending account to a receiving account.
// An error is returned upon failure.
func (k BaseSendKeeper) SendCoins(ctx sdk.Context, fromAddr sdk.AccAddress, toAddr sdk.AccAddress, amt sdk.Coins) error {
if err := k.SendEnabledCoins(ctx, amt...); err != nil {
return err
}

if k.BlockedAddr(toAddr) {
return sdkerrors.Wrapf(sdkerrors.ErrUnauthorized, "%s is not allowed to receive funds", toAddr)
}

ctx.EventManager().EmitEvents(sdk.Events{
sdk.NewEvent(
types.EventTypeTransfer,
Expand Down

0 comments on commit d34ef20

Please sign in to comment.