Skip to content

Commit

Permalink
fix(authz): error msg (#16869)
Browse files Browse the repository at this point in the history
Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>
  • Loading branch information
atheeshp and likhita-809 authored Jul 7, 2023
1 parent ac6df28 commit bf7a298
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
### Improvements

* (all) [#16537](https://github.com/cosmos/cosmos-sdk/pull/16537) Properly propagated fmt.Errorf errors + using errors.New where appropriate.
* (x/authz) [#16869](https://github.com/cosmos/cosmos-sdk/pull/16869) Error message has been improvised in `Exec` command when grant not found.

### Bug Fixes

Expand Down
3 changes: 2 additions & 1 deletion x/authz/keeper/keeper.go
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,8 @@ func (k Keeper) DispatchActions(ctx context.Context, grantee sdk.AccAddress, msg

grant, found := k.getGrant(ctx, skey)
if !found {
return nil, errorsmod.Wrapf(authz.ErrNoAuthorizationFound, "failed to update grant with key %s", string(skey))
return nil, errorsmod.Wrapf(authz.ErrNoAuthorizationFound,
"failed to get grant with given granter: %s, grantee: %s & msgType: %s ", sdk.AccAddress(granter), grantee, sdk.MsgTypeURL(msg))
}

if grant.Expiration != nil && grant.Expiration.Before(now) {
Expand Down
2 changes: 1 addition & 1 deletion x/authz/keeper/msg_server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ func (suite *TestSuite) TestExec() {
errMsg: "empty address string is not allowed",
},
{
name: "no existing grant",
name: "non existing grant",
malleate: func() authz.MsgExec {
return authz.NewMsgExec(grantee, []sdk.Msg{msg})
},
Expand Down

0 comments on commit bf7a298

Please sign in to comment.