Skip to content

Commit

Permalink
R4R: Fix duplicate json key in SetWithdrawAddress (#2944)
Browse files Browse the repository at this point in the history
* Fix duplicate json key

* Update PENDING.md
  • Loading branch information
hendrikhofstadt authored and jackzampolin committed Nov 29, 2018
1 parent 6258fde commit b773636
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions PENDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ BREAKING CHANGES
* [\#2798](https://github.com/cosmos/cosmos-sdk/issues/2798) Governance API has miss-spelled English word in JSON response ('depositer' -> 'depositor')
* [\#2943](https://github.com/cosmos/cosmos-sdk/pull/2943) Transaction action tags equal the message type. Stake EndBlocker tags are included.
* [\#2945](https://github.com/cosmos/cosmos-sdk/issues/2945) CreateValidator pubKey type is now validated against `ConsensusParams`
* [\#2944](https://github.com/cosmos/cosmos-sdk/pull/2944) Message SetWithdrawAddress had duplicate JSON field name ('delegator_addr' -> 'withdraw_addr')

* Tendermint
- Update to Tendermint 0.27.0
Expand Down
2 changes: 1 addition & 1 deletion x/distribution/types/msg.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ var _, _ sdk.Msg = &MsgWithdrawDelegatorReward{}, &MsgWithdrawValidatorRewardsAl
// msg struct for changing the withdraw address for a delegator (or validator self-delegation)
type MsgSetWithdrawAddress struct {
DelegatorAddr sdk.AccAddress `json:"delegator_addr"`
WithdrawAddr sdk.AccAddress `json:"delegator_addr"`
WithdrawAddr sdk.AccAddress `json:"withdraw_addr"`
}

func NewMsgSetWithdrawAddress(delAddr, withdrawAddr sdk.AccAddress) MsgSetWithdrawAddress {
Expand Down

0 comments on commit b773636

Please sign in to comment.