Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: zeropb codec #128

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

WIP: zeropb codec #128

wants to merge 9 commits into from

Conversation

elias-orijtech
Copy link

@elias-orijtech elias-orijtech force-pushed the zeropb branch 2 times, most recently from 5f30e39 to d05f41e Compare November 24, 2023 14:32
aaronc
aaronc reviewed Nov 24, 2023
View reviewed changes
Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the LitteEndian calls get inlined if the arch is little endian? I wonder what the performance is without those calls

@elias-orijtech
Copy link
Author

Do the LitteEndian calls get inlined if the arch is little endian? I wonder what the performance is without those calls

I believe LittleEndian calls are inlined on all platforms, but swizzled on big endian. For little endian, its just a single assembly instruction: see https://godbolt.org/z/v7d18GnoE assembly, line 14.

@elias-orijtech elias-orijtech force-pushed the zeropb branch 2 times, most recently from a538009 to 147022f Compare December 1, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronc aaronc aaronc left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elias-orijtech @aaronc