fix: make inmem bookmarks random for each run #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frezbo
approved these changes
Nov 5, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Unix4ever
approved these changes
Nov 5, 2024
19c9236 to
5c7c319
Compare
As inmem storage is not persisted, make sure watch bookmark from one run doesn't work with another run. This still allows watches to be restarted on connection failures, but if the watch is restarted on a program restart, bookmark won't match anymore. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
5c7c319 to
6dd2c2b
Compare
|
Verified with Talos Linux:
|
|
/m |
smira
added a commit
to smira/talos
that referenced
this pull request
Dec 12, 2024
Final Kubernetes release for Talos 1.9.0. Also update COSI to pull in a fix for watch restarts: cosi-project/runtime#512 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/talos
that referenced
this pull request
Dec 12, 2024
Final Kubernetes release for Talos 1.9.0. Also update COSI to pull in a fix for watch restarts: cosi-project/runtime#512 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/state-etcd
that referenced
this pull request
Dec 13, 2024
Catch up with cosi-project/runtime#512. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/talos
that referenced
this pull request
Dec 17, 2024
Final Kubernetes release for Talos 1.9.0. Also update COSI to pull in a fix for watch restarts: cosi-project/runtime#512 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com> (cherry picked from commit d45e8d1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As inmem storage is not persisted, make sure watch bookmark from one run doesn't work with another run.
This still allows watches to be restarted on connection failures, but if the watch is restarted on a program restart, bookmark won't match anymore.