Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed a situation where the action would hang forever (6hrs) if it failed to queue a run.
That's why I think we should exit early if queuing a run failed. I decided to check if
TGID
was empty after scheduling to determine if it worked.The alternative approach would be to
set -e
on the entireentrypoint.sh
script. Personally, I'd prefer that but I do not knowtestground
CLI well enough to judge if there are any situation in which we'd like to tolerate non-zero exit codes - which would prevent me from introducing this patch fix quickly.Let me know what you think :)
Testing
Failure case: https://github.com/galargh/go-ipfs/runs/5231923598?check_suite_focus=true
Success case: https://github.com/galargh/go-ipfs/runs/5232065515?check_suite_focus=true