Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Issue With Retrieving project_name in Release #180

Closed

Conversation

kbredemeier
Copy link
Contributor

If the operator is run in an Elixir release it crashes because Mix isn't available. Not sure what the intention was but here is my suggestion for a fix.

@mruoss
Copy link
Collaborator

mruoss commented Feb 2, 2023

Hmm... I see the problem with Mix. But is project_name() even called in your case? It should not be called if the config holds the right values... Can you find out?

@kbredemeier
Copy link
Contributor Author

Sorry, I was holding it wrong. I oversaw one of the other attributes depending on project_name. If I find the time I will look into improving the bonny.init task to have everything ready for building a release.

@mruoss
Copy link
Collaborator

mruoss commented Feb 13, 2023

Thanks for your feedback.

If I find the time I will look into improving the bonny.init task to have everything ready for building a release.

I'd very welcome that. Until then, can you elaborate on the mistake made?

@mruoss
Copy link
Collaborator

mruoss commented Feb 13, 2023

Ah sorry, I think I got it.

@kbredemeier
Copy link
Contributor Author

For clarification: I didn't configure one of the values that is derived from project_name if not specified.

@mruoss
Copy link
Collaborator

mruoss commented Feb 25, 2023

6971313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants