Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CRD apiextensions.k8s.io/v1 generation refs #117, #101 #143

Merged
merged 2 commits into from
Aug 31, 2022
Merged

Fix CRD apiextensions.k8s.io/v1 generation refs #117, #101 #143

merged 2 commits into from
Aug 31, 2022

Conversation

mruoss
Copy link
Collaborator

@mruoss mruoss commented Aug 31, 2022

No description provided.

@mruoss mruoss linked an issue Aug 31, 2022 that may be closed by this pull request
The current CRD from mix bonny.gen.manifest doesn't work on later version of k8s #117
Closed
This was referenced Aug 31, 2022
Closed
Closed
@mruoss
Copy link
Collaborator Author

mruoss commented Aug 31, 2022

Requires testing

@mruoss
Copy link
Collaborator Author

mruoss commented Aug 31, 2022

@sleipnir Can you confirm you have tested this change?

@sleipnir
Copy link

@sleipnir Can you confirm you have tested this change?

Yes, as I submitted evidence here. I tested it with your branch and it worked fine. The manifest has been applied and the CRDs have been successfully identified by the kubernetes api.

@mruoss
Copy link
Collaborator Author

mruoss commented Aug 31, 2022

perfect, thanks. I also adapted test env to work with apiextensions.k8s.io/v1.

@mruoss mruoss merged commit 0b39a9d into master Aug 31, 2022
@mruoss mruoss deleted the fix-v1-api-crd branch August 31, 2022 14:01
@mruoss mruoss mentioned this pull request Sep 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The current CRD from mix bonny.gen.manifest doesn't work on later version of k8s
2 participants
@mruoss @sleipnir