Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid JSON parsing when large watch streams are received #43

Closed
coryodaniel opened this issue Apr 11, 2019 · 0 comments
Closed

Invalid JSON parsing when large watch streams are received #43

coryodaniel opened this issue Apr 11, 2019 · 0 comments

Comments

@coryodaniel
Copy link
Owner

Environment

  • Bonny version: all
  • Elixir & Erlang/OTP versions (elixir --version): all
  • Operating system: all

Current behavior

If watching a resource with extremely high throughput, the streaming responses from k8s may be half of a JSON payload.

Current expectation is each chunk is a complete JSON event. Partial events cause process to crash and event to be lost.

Expected behavior

Buffer HTTP responses and parse when the entire response is present.
coryodaniel added a commit that referenced this issue Apr 11, 2019
@coryodaniel
Support CRD Reconciliation
86be737 
* [Added] support for a `reconcile/1` callback.Added support for a
`reconcile/1` callback.
* [ADDED] `reconcile_every` config option to schedule how often to run
reconciliation
* [ADDED] `reconcile_batch_size` to set the size of the HTTP GET limit
when fetching batches of items to reconcile
* [FIXED] receiving `:DOWN` messages no longer crashes Watcher #20
* [FIXED] issue with partially received events #43

Closes #43
Closes #20
Closes #30
@coryodaniel coryodaniel mentioned this issue Apr 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@coryodaniel