Adding a prefix when date is uncertain #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cgalarza thank you for this proposed contribution. I'm happy to include this change and will release a new version once it's merged. Before I merge it, could you please add translation entries for |
|
@corylown Whoops! I should have remembered to do that. I added in those translations. Just a heads up that I have another change/request in the works, in case you want to hold off on doing a release until after. Thanks for your help! |
corylown
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For uncertain dates, we'd like to support displaying something like, "possibly 2002". Approximate dates have a prefix and suffix, so I followed that example. I am not sure what the best way to test this is, let me know if you have any advice on that front. Thanks!